network: also read mtime of drop-in configs #16030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keszybz
reviewed
Jun 1, 2020
keszybz
reviewed
Jun 1, 2020
src/network/networkd-network.c
Outdated
|
|
||
| struct stat stats; | ||
| if (stat(filename, &stats) < 0) | ||
| return -errno; |
Member
There was a problem hiding this comment.
In other places where we do stat for this purpose, we set the mtime to 0 on error. I think that's nice than propagating the error. We'll just maybe reload the config unnecessarily later.
334ce26 to
7e7e8bf
Compare
Member
Author
|
@keszybz Thank you for the review. I've updated the commits with your suggestions. PTAL. |
keszybz
requested changes
Jun 1, 2020
src/network/networkd-network.c
Outdated
| usec_t t; | ||
|
|
||
| if (stat(*f, &stats) < 0) | ||
| continue; |
Member
There was a problem hiding this comment.
Hmm, that's not correct either. I think network->timestamp should be reset to 0 here and break.
7e7e8bf to
9f83091
Compare
Member
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15521.