Skip to content

Fix #15985 #15987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
0x2b3bfa0 wants to merge 1 commit into from
Closed

Fix #15985 #15987

0x2b3bfa0 wants to merge 1 commit into from
+6 −1

Conversation

@0x2b3bfa0
Copy link

@0x2b3bfa0 0x2b3bfa0 commented May 31, 2020

Fixes #15985 by making sure that parsed user identifiers don't contain characters outside the [0-9] range.

@0x2b3bfa0 0x2b3bfa0 mentioned this pull request May 31, 2020
Closed
@0x2b3bfa0 0x2b3bfa0 marked this pull request as draft May 31, 2020 13:40
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review May 31, 2020 14:41
@keszybz
Copy link
Member

keszybz commented May 31, 2020

I created a patch before I saw your pull request, see #15991.

@keszybz
Copy link
Member

keszybz commented May 31, 2020

Oh, in particular your patch rejects 01234, but id and other tools parse that as a decimal number. I think we should do the same, it would create a pointless difference to do anything different. So I'll close this in favour of #15991, since the implementation there is a bit nicer.

@keszybz keszybz closed this May 31, 2020
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request May 31, 2020
Merged
@0x2b3bfa0
Copy link
Author

0x2b3bfa0 commented May 31, 2020 •
edited
Loading

👌 :shipit: Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

User names beginning with 0x being interpreted as user identifiers

2 participants

@0x2b3bfa0 @keszybz