network: fix double free in macsec_receive_channel_free() #15963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10443b8 to
0e64e49
Compare
poettering
requested changes
May 29, 2020
src/network/netdev/macsec.c
Outdated
|
|
||
| stored = ordered_hashmap_get(c->macsec->receive_channels, &c->sci.as_uint64); | ||
| if (stored == c) | ||
| ordered_hashmap_remove(c->macsec->receive_channels, &c->sci.as_uint64); |
Member
There was a problem hiding this comment.
hmm, for the regular hashmaps there's hashmap_remove_value() which makes this comparison implicitly. I think we should just add a similar helper call ordered_hashmap_remove_value() and use that here.
0e64e49 to
38b84e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15941.