Skip to content

"make check" broken since unified cgroup rework if cgroupfs is not mounted #1132

@martinpitt

Description

@martinpitt

Since commit efdb023 ("core: unified cgroup hierarchy support") I am seeing 4 test case failures during "make check", in test-engine, test-path, test-sched-prio, and test-bus-creds. They all fail for the same reason:

$ SYSTEMD_LOG_LEVEL=debug ./test-path
Cannot determine cgroup we are running in: Exec format error
Assertion 'r >= 0' failed at src/test/test-path.c:47, function setup_test(). Aborting.
Aborted (core dumped)

This negative r result comes from manager_new(MANAGER_USER, true, &tmp);

This only happens in a build chroot, the test programs run fine in my "real" system. Once I bind-mount /sys/fs/cgroup into the chroot it works again, but introducing this requirement would mean that we have to stop running these tests on package build as our production buildds don't do this. Was introducing this requirement deliberate, or at least unavoidable? If so I'm okay with disabling the tests, but I'd like to ask first.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions