network: enable GatewayOnLink= if Gateway= without static address configured

yuwata · yuwata · commit 4912ab7774cc · 2019-02-28T10:34:21.000+09:00
And warn about that.

But this only done if GatewayOnLink= is not specified. When it is
explicitly disabled, then the flag will not be set.
diff --git a/src/network/networkd-network.c b/src/network/networkd-network.c
@@ -293,16 +293,27 @@ static int network_verify(Network *network) {
                         address_free(address);
                 }
 
-        LIST_FOREACH_SAFE(routes, route, route_next, network->static_routes)
+        LIST_FOREACH_SAFE(routes, route, route_next, network->static_routes) {
                 if (route->family == AF_UNSPEC) {
                         log_warning("%s: Route section without Gateway=, Destination=, Source=, "
                                     "or PreferredSource= field configured. "
                                     "Ignoring [Route] section from line %u.",
                                     network->filename, route->section->line);
 
                         route_free(route);
+                        continue;
                 }
 
+                if (network->n_static_addresses == 0 &&
+                    in_addr_is_null(route->family, &route->gw) == 0 &&
+                    route->gateway_onlink < 0) {
+                        log_warning("%s: Gateway= without static address configured. "
+                                    "Enabling GatewayOnLink= option.",
+                                    network->filename);
+                        route->gateway_onlink = true;
+                }
+        }
+
         return 0;
 }
 
