Rename some opts to be more consistent#3201
Merged
daandemeyer merged 1 commit intosystemd:mainfrom Nov 18, 2024
Merged
Conversation
behrmann
approved these changes
Nov 17, 2024
Contributor
behrmann
left a comment
There was a problem hiding this comment.
I like the longer name a bit better and changing it from -directory to -dir leaves the --directory option, but it's still more consistent than the status quo.
Contributor
Author
|
I am also fine with changing them all to use the longer |
Contributor
|
Let's have @daandemeyer weigh in, since he just added another. Either way this PR will need a rebase. |
464ad4b to
b450eb5
Compare
Contributor
Author
|
Changed them to the longer |
b450eb5 to
baba0f6
Compare
daandemeyer
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just noticed some directory long opts used
dir=while others useddirectory=, should all now be consistentlydirectory=.