Add special handling for unexpected COM_PING packets#5257
Conversation
Summary of ChangesHello @JavierJF, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a specific scenario where Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a workaround for handling unexpected COM_PING packets from clients. The changes involve queuing these pings and sending back OK packets at the end of a query to prevent client hangs. The implementation is sound, but there's a critical issue in how response packet sequence IDs are handled, which could break client-server communication. Additionally, there are several opportunities for code improvement in the new test files, including simplifying a random string generation function and addressing potential memory leaks and correctness issues in the test logic.
Implements a workaround for the handling of unexpected 'COM_PING' packets received during query processing, while a resultset is yet being streamed to the client. Received 'COM_PING' packets are queued in the form of a counter. This counter is later used to sent the corresponding number of 'OK' packets to the client after 'MySQL_Session' has finished processing the current query.
Also fixes 'random_string' utility function for large strings, avoiding the previous shuffle repetition from the dictionary.
dfc39aa to
503b097
Compare
Logging messages now include 'client address', 'session status' and 'data stream status'. Client address is also logged when OK packets are dispatched, this should help tracking if a client has received the expected packets or not.
|
Retest this please. |
- Fixed was changing server defaults ('max_allowed_packet') in the same
connection as the subsequent INSERT.
- Use direct MySQL connection for table/data preparation.
- ProxySQL connection pool required cleanup 'connection_pool' to ensure
defaults reload.
3f8d558 to
e73ba2b
Compare
|
Description
Implements a workaround for the handling of unexpected 'COM_PING' packets received during query processing, while a resultset is yet being streamed to the client. Received 'COM_PING' packets are queued in the form of a counter. This counter is later used to sent the corresponding number of 'OK' packets to the client after 'MySQL_Session' has finished
processing the current query.