Skip to content

Ensure default mysql-interfaces=0.0.0.0:6033 and pgsql-interfaces=0.0.0.0:6133 are set#5190

Merged
renecannao merged 1 commit intov3.0from
v3.0_default_interface_global_var_5189
Nov 4, 2025
Merged

Ensure default mysql-interfaces=0.0.0.0:6033 and pgsql-interfaces=0.0.0.0:6133 are set#5190
renecannao merged 1 commit intov3.0from
v3.0_default_interface_global_var_5189

Conversation

@rahim-kanji
Copy link
Collaborator

@rahim-kanji rahim-kanji commented Oct 30, 2025 •
edited
Loading

Closes #5189

@gemini-code-assist
Copy link

gemini-code-assist bot commented Oct 30, 2025

Summary of Changes

Hello @rahim-kanji, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the default network interfaces for MySQL and PostgreSQL were not explicitly set, leading to potential binding issues. By hardcoding the mysql-interfaces and pgsql-interfaces variables to 0.0.0.0 with their respective default ports, the change ensures that ProxySQL's database listeners are correctly initialized to listen on all available network interfaces, improving out-of-the-box usability and resolving a reported bug.

Highlights

  • Default MySQL Interface: The default mysql-interfaces variable is now explicitly set to 0.0.0.0:6033 in lib/MySQL_Thread.cpp, ensuring MySQL listeners bind to all available network interfaces on port 6033 by default.
  • Default PostgreSQL Interface: The default pgsql-interfaces variable is now explicitly set to 0.0.0.0:6133 in lib/PgSQL_Thread.cpp, ensuring PostgreSQL listeners bind to all available network interfaces on port 6133 by default.
  • Minor Formatting Fixes: Small indentation and brace alignment fixes were applied in lib/PgSQL_Thread.cpp and lib/ProxySQL_Config.cpp.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 30, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default values for mysql-interfaces and pgsql-interfaces to listen on all network interfaces (0.0.0.0) on ports 6033 and 6133, respectively. Previously, these defaults were empty strings, requiring explicit configuration to enable network listeners.

While this change improves the out-of-the-box experience, it has security implications. Binding to 0.0.0.0 by default may expose ProxySQL to unintended networks. My review includes suggestions to add inline comments to the code to highlight this security consideration for administrators and future developers.

The other changes in this pull request are minor formatting adjustments.

@rahim-kanji rahim-kanji marked this pull request as draft October 30, 2025 08:51
@rahim-kanji rahim-kanji force-pushed the v3.0_default_interface_global_var_5189 branch from 76805c9 to 48928ce Compare October 30, 2025 21:57
@rahim-kanji rahim-kanji marked this pull request as ready for review October 30, 2025 21:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 30, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@rahim-kanji rahim-kanji added this to the Release 3.0.3 milestone Oct 31, 2025
@rahim-kanji
Copy link
Collaborator Author

rahim-kanji commented Oct 31, 2025

retest this please

@renecannao renecannao merged commit 8be9107 into v3.0 Nov 4, 2025
144 of 154 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 3.0.3

Development

Successfully merging this pull request may close these issues.

ProxySQL should populate default mysql-interfaces=0.0.0.0:6033 and pgsql-interfaces=0.0.0.0:6133 in global_variables when not defined in config

2 participants

@rahim-kanji @renecannao