Skip to content

Resolved issues with PROXYSQL PAUSE/RESUME/STOP/START#5173

Merged
renecannao merged 3 commits intov3.0from
v3.0_admin_cmd_5170
Oct 24, 2025
Merged

Resolved issues with PROXYSQL PAUSE/RESUME/STOP/START#5173
renecannao merged 3 commits intov3.0from
v3.0_admin_cmd_5170

Conversation

@rahim-kanji
Copy link
Collaborator

@rahim-kanji rahim-kanji commented Oct 22, 2025

Closes #5170

@gemini-code-assist
Copy link

gemini-code-assist bot commented Oct 22, 2025

Summary of Changes

Hello @rahim-kanji, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and resolves several issues related to the PROXYSQL administrative commands, specifically START, STOP, PAUSE, and RESUME. The changes extend the functionality of these commands to properly manage both MySQL and PostgreSQL modules within ProxySQL, ensuring consistent behavior and improved error handling. Additionally, a new command for flushing PostgreSQL client hosts has been introduced, and general code cleanup for mutex handling and logging has been performed.

Highlights

  • Unified Module Management for START/STOP: The PROXYSQL START and PROXYSQL STOP commands now correctly manage both MySQL and PostgreSQL modules, ensuring a consistent state across both and preventing operations on already stopped modules.
  • Enhanced PAUSE/RESUME Logic: The PROXYSQL PAUSE and PROXYSQL RESUME commands have improved error handling and now consider the state of both MySQL and PostgreSQL modules, preventing redundant operations and providing clearer feedback.
  • New PostgreSQL Command: A new command, PROXYSQL FLUSH PGSQL CLIENT HOSTS, has been introduced to allow flushing the PostgreSQL client host cache.
  • Improved Logging and Mutex Handling: The flush_logs function now includes PostgreSQL logger flushing, and the mutex unlock logic in the admin session handler has been simplified for cleaner execution.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 22, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request commendably extends the PROXYSQL PAUSE/RESUME/STOP/START commands to manage the PgSQL module, mirroring the existing logic for the MySQL module. While this is a valuable enhancement, it has introduced some code duplication that could be refactored for better maintainability. More critically, a change in admin_session_handler appears to reintroduce a use-after-free bug when handling PROXYSQL STOP, which was correctly addressed in the previous version. My review provides suggestions to resolve these issues.

@rahim-kanji rahim-kanji added this to the Release 3.0.3 milestone Oct 22, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@renecannao renecannao merged commit 4a6ba68 into v3.0 Oct 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 3.0.3

Development

Successfully merging this pull request may close these issues.

Confusing results using PROXYSQL PAUSE/RESUME

2 participants

@rahim-kanji @renecannao