Skip to content

V3.0.3 upgrade coredumper to percona fork hash 8f2623b#5171

Merged
renecannao merged 1 commit intov3.0from
v3.0.3-upgrade_coredumper
Oct 24, 2025
Merged

V3.0.3 upgrade coredumper to percona fork hash 8f2623b#5171
renecannao merged 1 commit intov3.0from
v3.0.3-upgrade_coredumper

Conversation

@mirostauder
Copy link
Contributor

@mirostauder mirostauder commented Oct 22, 2025

upgrade coredumper to percona fork
from hash cb6cead to 8f2623b (current head)

adds some fixes on top of upstream

dropping unneeded patch

@mirostauder mirostauder added this to the Release 3.0.3 milestone Oct 22, 2025
@mirostauder mirostauder self-assigned this Oct 22, 2025
@gemini-code-assist
Copy link

gemini-code-assist bot commented Oct 22, 2025

Summary of Changes

Hello @mirostauder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the coredumper library to a more recent version from the Percona fork. This update is significant as it brings a suite of fixes and enhancements directly into the dependency, improving its compatibility with modern build systems like CMake 4.0, enhancing GDB debugging capabilities, and refining the quality of generated core dumps. A key benefit of this upgrade is the ability to remove a previously necessary local patch, simplifying the codebase and dependency management.

Highlights

  • Coredumper Upgrade: The coredumper dependency has been upgraded to a newer commit (8f2623b) from the Percona fork, moving from the previous hash cb6cead.
  • Incorporated Fixes: This upgrade integrates several fixes from the Percona fork, including improvements for include directives, CMake 4.0 compatibility, GDB functionality, and overall improved core dump generation.
  • Patch Removal: An existing local patch, includes.patch, has been removed as its functionality is now natively included in the upgraded coredumper version.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 22, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 22, 2025
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the coredumper dependency to a more recent version from the Percona fork, updating the version identifier and removing an obsolete patch file. The changes are straightforward and correct. I have added one comment regarding the removed patch, highlighting a potential pre-existing issue in the build process that this change makes apparent.

@mirostauder mirostauder changed the title upgrade coredumper to percona fork hash 8f2623b V3.0.3 upgrade coredumper to percona fork hash 8f2623b Oct 22, 2025
@renecannao renecannao merged commit 0801450 into v3.0 Oct 24, 2025
5 of 6 checks passed
@renecannao renecannao deleted the v3.0.3-upgrade_coredumper branch March 7, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renecannao renecannao Awaiting requested review from renecannao

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mirostauder mirostauder

Labels

None yet

Projects

None yet

Milestone

Release 3.0.3

Development

Successfully merging this pull request may close these issues.

2 participants

@mirostauder @renecannao