Summary of Changes

Hello @rahim-kanji, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the PostgreSQL search_path parameter into ProxySQL's variable tracking system to resolve session locking issues. It introduces a new validator for search_path, refines SET statement parsing with a new flag for conditional quote stripping, and cleans up obsolete code.

Highlights

• Intent: This pull request aims to add the PostgreSQL search_path parameter to the list of variables tracked by ProxySQL. The primary motivation is to prevent sessions from being locked on a hostgroup, which previously occurred because search_path changes were not properly monitored. This change directly addresses issue Add search_path parameter to tracked ProxySQL variables list - PgSQL #5148.
• Key Changes: The core of this PR involves integrating search_path into ProxySQL's variable tracking mechanism. This required several modifications:

1. search_path Tracking: A new enum entry PGSQL_SEARCH_PATH was added, along with a dedicated validator function (pgsql_variable_validate_search_path) to handle its specific parsing and validation rules (e.g., quoted identifiers, commas, spaces).
2. Quote Handling: A new option PGTRACKED_VAR_OPT_NO_STRIP_VALUE was introduced to control whether quotes should be stripped from a variable's value during parsing. This is crucial for search_path values like "$user", public where quotes are significant. The SET statement handling logic was updated to respect this new flag.
3. SET Statement Parsing Refinement: The PgSQL_Set_Stmt_Parser's regex was updated to be more robust in parsing SET statements, accommodating various syntaxes and operators (e.g., =, TO, or implicit space). An older, unused parse2() method was removed.
4. Code Cleanup: Unused code related to is_select_NOT_for_update in PgSQL_PreparedStatement and PgSQL_Session was removed, streamlining the codebase.
5. Minor Improvements: strncasecmp was replaced with strcasecmp for client_encoding comparison, and error handling for SET statements was slightly refined.

• Impact: By tracking the search_path variable, ProxySQL can now correctly manage session state and prevent hostgroup locking issues that arose from its untracked changes. The improved SET statement parsing and flexible quote handling ensure that PostgreSQL variables, especially those with complex values like search_path, are handled accurately.

Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE