Align DateStyle parsing with PostgreSQL#5144
Conversation
Updated PgSQL_DateStyle_Util::parse_datestyle() to support prefix-based matching for known tokens (POSTGRES, EURO, NONEURO). This allows variants like "PostgreSQL", "European", to be recognized as valid inputs.
Summary of ChangesHello @rahim-kanji, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
There was a problem hiding this comment.
Code Review
This pull request correctly aligns the DateStyle parsing with PostgreSQL's prefix-matching behavior for keywords like POSTGRES, EURO, and NONEURO. The changes are implemented using strncasecmp which is appropriate for case-insensitive prefix comparison. The addition of test cases in pgsql-set_parameter_validation_test-t.cpp is great and ensures the new functionality is well-tested.
My feedback focuses on a minor stylistic improvement to make the code more idiomatic to modern C++, by replacing the C-style sizeof("LITERAL") - 1 with std::string_view("LITERAL").length() for getting the length of string literals. This improves readability without any performance cost.
Updated
PgSQL_DateStyle_Util::parse_datestyle()to support prefix-based matching for known tokens (POSTGRES,EURO,NONEURO). This allows variants like "PostgreSQL" and "European" to be recognized as valid inputs. The change improves compatibility and consistency with PostgreSQL’s DateStyle parsing behavior.PostgreSQLis treated the same asPOSTGRES,EURO/EUROPEANmap toDMY, andNONEURO/USmap toMDY