Fix certificate chain send during SSL handshake - Closes #4877#4904
Merged
renecannao merged 1 commit intov3.0from Apr 10, 2025
Merged
Fix certificate chain send during SSL handshake - Closes #4877#4904renecannao merged 1 commit intov3.0from
renecannao merged 1 commit intov3.0from
Conversation
Removed usages of 'SSL_CTX_add_extra_chain_cert'. Manually adding certs to the certificate chain shouldn't be required, using 'SSL_CTX_load_verify_locations' with the right arguments should be enough, allowing OpenSSL to correctly select the certificates to be used for validation purposes.
Collaborator
Author
|
Retest this please. |
1 similar comment
Collaborator
Author
|
Retest this please. |
|
can it be backported to 2.7 branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed usages of 'SSL_CTX_add_extra_chain_cert'. Manually adding certs to the certificate chain shouldn't be required, using 'SSL_CTX_load_verify_locations' with the right arguments should be enough for the current use case. This way the selection of certificates sent during handshake for verification purposes is automatically handled by OpenSSL.
Closes #4877.