Add MySQL compression level variable and change default to compression level 3 (v3.0)#4764
Merged
renecannao merged 12 commits intov3.0from Jan 22, 2025
Merged
Add MySQL compression level variable and change default to compression level 3 (v3.0)#4764renecannao merged 12 commits intov3.0from
renecannao merged 12 commits intov3.0from
Conversation
JavierJF
requested changes
Dec 2, 2024
Collaborator
JavierJF
left a comment
There was a problem hiding this comment.
Comments and changes are focused on the TAP test, there are also some suggestions. Thanks!
1. Moved monotonic_time to util 2. Now calculate_query_execution_time will return -1 incase of error. 3. Using util function for setting and getting compression variable values. 4. Added mysql_query_rules
JavierJF
reviewed
Dec 18, 2024
JavierJF
reviewed
Jan 8, 2025
2. Changed performance diff to float in tap test
JavierJF
requested changes
Jan 9, 2025
JavierJF
reviewed
Jan 9, 2025
Contributor
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default compression level was 6 for MySQL clients and this was making ProxySQL slower.
Following changes has been made:
For detail of issue, #4721