Second iteration on PostgreSQL monitoring POC - Read-Only Support#4726
Merged
renecannao merged 2 commits intov3.0from Nov 11, 2024
Merged
Second iteration on PostgreSQL monitoring POC - Read-Only Support#4726renecannao merged 2 commits intov3.0from
renecannao merged 2 commits intov3.0from
Conversation
Contributor
|
Can one of the admins verify this patch? |
b37713c to
ca61c1f
Compare
Contributor
|
retest this please |
This commit packs multiple fixes/improvements:
- Added READONLY support for PostgreSQL.
- Major rework for queries and statements used on monitoring checks:
+ Checks/Actions rewrote for single instance checks.
+ Reuse of prepared statements instance of re-preparation.
- Fixed missing error handling in connection creation state machine.
- Fixed connection rotation in connection pool (now FIFO).
- Added support for configurable batching in scheduler thread, via
'*_interval_window' variables. These variables allows to define the
burstiness of the scheduling within the processing interval.
- Added new config variable 'pgsql-monitor_dbname'. Allows to control
which 'db' will be target by monitoring connections.
- Several fixes for 'poll' timeout computation for worker threads.
- Fixed edge cases for current interval detection.
- Reduced deviation in scheduling intervals computation.
- Refactored and simplified connection event handling.
- Improved error messages for monitoring actions.
- Replaced several invalid uses of 'mysql_thread___monitor_*' in
favor or new 'mysql_thread___monitor_*' variables.
- Honor '-M' argument for disabling monitoring support.
ca61c1f to
12a5c31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR packs multiple fixes/improvements:
'*_interval_window' variables. These variables allows to define the
burstiness of the scheduling within the processing interval.
which 'db' will be target by monitoring connections.
favor or new 'mysql_thread___monitor_' variables.
There are still a couple of missing points on the implementation, these are flagged as TODO in the code itself.