feat: add possibility to get modules#170
Conversation
|
getModules is a confusing API. How should I know as a developer that it returns only static modules and not both static and dynamic? |
|
I'd prefer to have an API like |
|
Maybe it's okay to not distinguish between static and dynamic modules and return all module paths, i.e. have |
|
@larixer Could you please provide me with your feedback on whether I have extracted the dynamic modules correctly? Thank you. |
|
@fyodorovandrei Many thanks, looks good! |
|
@fyodorovandrei Published as |
|
Nice! Thank you @larixer |
What's the problem this PR addresses?
I needed to access the static modules multiple times. As shown in the links, people require them.
https://github.com/module-federation/universe/blob/main/packages/storybook-addon/src/lib/storybook-addon.ts#L81
https://github.com/nuxt-modules/storybook/blob/95cd445eed0cdc570bbfba03ff9589c727a41ee8/src/webpack.ts#L32C99-L32C99
...
How did you fix it?
A new method has been added to retrieve static modules.
...