fix: ensure syrupy's pytest_assertrepr_compare hook is called first.#984
Merged
noahnu merged 1 commit intosyrupy-project:mainfrom Jun 4, 2025
rahuliyer95:fix/assert-hook
Merged
fix: ensure syrupy's pytest_assertrepr_compare hook is called first.#984noahnu merged 1 commit intosyrupy-project:mainfrom rahuliyer95:fix/assert-hook
syrupy's pytest_assertrepr_compare hook is called first.#984noahnu merged 1 commit intosyrupy-project:mainfrom
rahuliyer95:fix/assert-hook
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #984 +/- ##
=======================================
Coverage 97.32% 97.33%
=======================================
Files 21 21
Lines 1685 1686 +1
=======================================
+ Hits 1640 1641 +1
Misses 45 45 🚀 New features to boost your workflow:
|
noahnu
approved these changes
Jun 4, 2025
Collaborator
|
@all-contributors add @rahuliyer95 for bug |
Contributor
|
I've put up a pull request to add @rahuliyer95! 🎉 |
Collaborator
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
syrupywith pytest-clarity thepytest_assertrepr_compareis called frompytest-clarity. This PR ensuresyrupy'spytest_assertrepr_compareis called first which gives it the ability to handleSnapshotAssertionbefore any other plugin. The code already does an early exit if theleftorrightvalue(s) are notSnapshotAssertionand automatically falling back to any other plugin that implementspytest_assertrepr_compare.Related Issues
N/A
Checklist
Additional Comments
No additional comments.