Skip to content

fix(backup): add boosts & transfers to backup #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pwltr merged 2 commits into from
Nov 27, 2024
Merged

fix(backup): add boosts & transfers to backup #2128

pwltr merged 2 commits into from
Nov 27, 2024

Conversation

@pwltr
Copy link
Collaborator

@pwltr pwltr commented Aug 9, 2024 •
edited
Loading

Description

Adds boostedTransactions and transfers from wallet state to backup & restore.

Linked Issues/Tasks

Closes #1844 #1868

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshots

Simulator Screenshot - iPhone 16 - 2024-11-26 at 17 10 08

Screenshot shows activity after restore:

  • 1 received tx
  • 1 sent tx not boosted (1000 sats)
  • 1 sent tx boosted (1000 sats)
  • 2 transfers to spending

@pwltr pwltr mentioned this pull request Aug 9, 2024
Closed
limpbrains
limpbrains reviewed Aug 12, 2024
View reviewed changes
@limpbrains
Copy link
Contributor

limpbrains commented Oct 9, 2024

I think we should merge this

@pwltr pwltr force-pushed the fix/wallet-backup branch from 6f952f6 to 0f96482 Compare November 26, 2024 16:38
@pwltr pwltr marked this pull request as ready for review November 26, 2024 16:41
@pwltr pwltr requested a review from limpbrains November 27, 2024 08:20
limpbrains
limpbrains approved these changes Nov 27, 2024
View reviewed changes
e2e/boost.e2e.js
Comment on lines +275 to +276
const seed = await getSeed();
await restoreWallet(seed);
Copy link
Contributor

@limpbrains limpbrains Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@pwltr pwltr merged commit 5124260 into master Nov 27, 2024
7 checks passed
@pwltr pwltr deleted the fix/wallet-backup branch November 27, 2024 11:24
@catch-21
Copy link
Collaborator

catch-21 commented Nov 28, 2024 •
edited
Loading

Tested on https://github.com/synonymdev/bitkit/tree/release-v1.0.7

  • Normal send boosted (RBF)

The following checks are for successful back up and restore:

  • Ongoing Transfer from Savings
  • Confirmed Transfer from Savings
  • Boosted ongoing Transfer from Savings
  • Boosted confirmed Transfer from Savings
  • Ongoing Transfer from Spending
  • Confirmed Transfer from Spending
  • Boosted ongoing Transfer from Spending
    • Works but still shows the separate 'Sent' activity for the CPFP tx, which is redundant given the 'Boosting' transfer activity, see screenshot and video below
Screenrecorder-2024-11-28-13-51-04-720.mp4
  • Boosted confirmed Transfer from Spending
    • This restored as separate Received and Sent activities (first is the transfer and second is the cpfp boost), see screenshots below.

@pwltr
Copy link
Collaborator Author

pwltr commented Nov 28, 2024

Tested on https://github.com/synonymdev/bitkit/tree/release-v1.0.7

The following checks are for successful back up and restore:

  • Ongoing Transfer from Savings
  • Confirmed Transfer from Savings
  • Boosted ongoing Transfer from Savings
  • Boosted confirmed Transfer from Savings
  • Ongoing Transfer from Spending
  • Confirmed Transfer from Spending
  • Boosted ongoing Transfer from Spending
  • Boosted confirmed Transfer from Spending

Thanks for this list, I only tested transfer to spending and boosting basic send. Will revisit this again.

@pwltr pwltr mentioned this pull request Jan 7, 2025
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@limpbrains limpbrains limpbrains approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pwltr pwltr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Restored wallet splits Boosted CPFP transactions into separate activities

4 participants

@pwltr @limpbrains @catch-21