Skip to content

Fix typo for UDM startup script#63

Merged
synfinatic merged 1 commit into
synfinatic:mainfrom
ProfMoo:main
May 25, 2021
Merged

Fix typo for UDM startup script#63
synfinatic merged 1 commit into
synfinatic:mainfrom
ProfMoo:main

Conversation

@ProfMoo

@ProfMoo ProfMoo commented May 25, 2021

Copy link
Copy Markdown
Contributor

The typo should definitely be fixed, but I'm not entirely sure about the Dockerfiles. I figured that we didn't need them, so I'd go ahead and remove them. If we still need them, then I can submit a PR with just the typo fix.

@synfinatic

synfinatic commented May 25, 2021

Copy link
Copy Markdown
Owner

Those Dockerfiles are for build release. so unless you have another way of building binaries for those platforms???

Note: due to the dependency on CGO, cross compiling is required and I develop on OSX.

Edit: the typo should be fixed (could of sworn I had already fixed that???). If you want to update your PR, please squash your commits so there is a single commit for me to merge.

@ProfMoo

ProfMoo commented May 25, 2021

Copy link
Copy Markdown
Contributor Author

Ohhh I see. You use the Dockerfile to build the binary even though the built Docker image wouldn't actually run on the "target" architecture? So the Dockerfile.arm64 file would build a binary for ARM64, but wouldn't be able to run on ARM64 architecture.

Since that's the case, I'll just fix the typo in this PR.

Note: I think what you are remembering is this branch: https://github.com/synfinatic/udp-proxy-2020/blob/fix-script/startup-scripts/udm-utilities/on_boot.d/40-udp-proxy-2020.sh

@synfinatic synfinatic changed the title Fix typo, remove unnecessary Dockerfiles Fix typo for UDM startup script May 25, 2021
@synfinatic synfinatic merged commit 36fd12a into synfinatic:main May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants