Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #966 +/- ##
==========================================
+ Coverage 84.36% 84.60% +0.24%
==========================================
Files 42 42
Lines 3057 3059 +2
==========================================
+ Hits 2579 2588 +9
+ Misses 384 378 -6
+ Partials 94 93 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
- add `login` command to do the needful. This is the only way now. - Commands which do not need to access the AWS SSO API do not require login - Deprecate `flush -t sso` Fixes: #291
Flush command is overly complex/confusing and not really needed as users can/should just use the `logout` command Refs: #626
Flush command is overly complex/confusing and not really needed as users can/should just use the `logout` command Refs: #626
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
logincommand to do the needful. This is the only way now.flush -t ssoFixes: #291