Skip to content

Fix --threads cli arg#959

Merged
synfinatic merged 1 commit intomainfrom
merge-v2
Jul 10, 2024
Merged

Fix --threads cli arg#959
synfinatic merged 1 commit intomainfrom
merge-v2

Conversation

@synfinatic
Copy link
Owner

  • We were ignoring the cache --threads option

Fixes: #658

@synfinatic synfinatic added this to the 1.17.0 milestone Jul 10, 2024
* We were ignoring the `cache --threads` option

Fixes: #658
@codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.14%. Comparing base (b3f7ca9) to head (51fb4ee).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #959   +/-   ##
=======================================
  Coverage   84.14%   84.14%           
=======================================
  Files          42       42           
  Lines        3058     3058           
=======================================
  Hits         2573     2573           
  Misses        392      392           
  Partials       93       93           
Flag Coverage Δ
unittests 84.14% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sso/cache.go 54.57% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3f7ca9...51fb4ee. Read the comment docs.

@synfinatic synfinatic changed the title Fix --threads and remove tags --force-update Fix --threads cli arg Jul 10, 2024
@synfinatic synfinatic merged commit e542e22 into main Jul 10, 2024
@synfinatic synfinatic deleted the merge-v2 branch July 10, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--threads X flag doesn't do anything

1 participant