Skip to content

ConfigProfilesUrlAction defaults to UrlAction#947

Merged
synfinatic merged 1 commit intomainfrom
configprofilesaction
Jul 7, 2024
Merged

ConfigProfilesUrlAction defaults to UrlAction#947
synfinatic merged 1 commit intomainfrom
configprofilesaction

Conversation

@synfinatic
Copy link
Owner

ConfigProfilesUrlAction no longer defaults to url, but whatever UrlAction is set to.

Fixes: #946

@codecov
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.90%. Comparing base (af902d4) to head (9db307b).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #947      +/-   ##
==========================================
+ Coverage   83.86%   83.90%   +0.04%     
==========================================
  Files          41       41              
  Lines        3005     3013       +8     
==========================================
+ Hits         2520     2528       +8     
  Misses        392      392              
  Partials       93       93              
Flag Coverage Δ
unittests 83.90% <57.89%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/url/url.go 90.91% <100.00%> (+0.37%) ⬆️
sso/settings.go 77.67% <38.46%> (+0.21%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af902d4...9db307b. Read the comment docs.

@synfinatic synfinatic force-pushed the configprofilesaction branch 3 times, most recently from 6049b32 to fcd9c2e Compare July 7, 2024 23:09
ConfigProfilesUrlAction no longer defaults to url, but
whatever UrlAction is set to.

Fixes: #946
@synfinatic synfinatic force-pushed the configprofilesaction branch from fcd9c2e to 9db307b Compare July 7, 2024 23:16
@synfinatic synfinatic merged commit ecba0f2 into main Jul 7, 2024
@synfinatic synfinatic deleted the configprofilesaction branch July 7, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConfigProfilesAction should default to UrlAction and not open

1 participant