Skip to content

Update cache during login IFF relevant settings change#941

Merged
synfinatic merged 1 commit intomainfrom
config-update-555-2
Jul 6, 2024
Merged

Update cache during login IFF relevant settings change#941
synfinatic merged 1 commit intomainfrom
config-update-555-2

Conversation

@synfinatic
Copy link
Owner

Port change from v2 branch

Refs: #555

@synfinatic synfinatic added this to the 1.17.0 milestone Jul 6, 2024
@codecov
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.86%. Comparing base (d0eb93c) to head (94dd91e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
+ Coverage   83.81%   83.86%   +0.05%     
==========================================
  Files          41       41              
  Lines        2989     3005      +16     
==========================================
+ Hits         2505     2520      +15     
- Misses        391      392       +1     
  Partials       93       93              
Flag Coverage Δ
unittests 83.86% <93.75%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sso/config.go 93.69% <100.00%> (+0.76%) ⬆️
sso/cache.go 54.57% <75.00%> (+0.24%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0eb93c...94dd91e. Read the comment docs.

@synfinatic synfinatic merged commit 28af09a into main Jul 6, 2024
@synfinatic synfinatic deleted the config-update-555-2 branch July 6, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant