Skip to content

Add --server flag for ecs client commands#940

Merged
synfinatic merged 1 commit intomainfrom
ecs-client-server-flag
Jul 6, 2024
Merged

Add --server flag for ecs client commands#940
synfinatic merged 1 commit intomainfrom
ecs-client-server-flag

Conversation

@synfinatic
Copy link
Owner

Add support for connecting to a random server

Fixes: #937

@codecov
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.81%. Comparing base (afaeeaf) to head (3479dfe).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #940      +/-   ##
==========================================
+ Coverage   83.77%   83.81%   +0.03%     
==========================================
  Files          41       41              
  Lines        2983     2989       +6     
==========================================
+ Hits         2499     2505       +6     
  Misses        391      391              
  Partials       93       93              
Flag Coverage Δ
unittests 83.81% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/ecs/client/client.go 92.86% <100.00%> (+0.40%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afaeeaf...3479dfe. Read the comment docs.

@synfinatic synfinatic force-pushed the ecs-client-server-flag branch from 86a814e to 0e35d75 Compare July 6, 2024 05:27
Add support for connecting to a random server

Fixes: #937
@synfinatic synfinatic force-pushed the ecs-client-server-flag branch from 0e35d75 to 3479dfe Compare July 6, 2024 14:55
@synfinatic synfinatic merged commit d0eb93c into main Jul 6, 2024
@synfinatic synfinatic deleted the ecs-client-server-flag branch July 6, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ecs client should prefer support other hosts than localhost

1 participant