Skip to content

refactor internal/utils into smaller packages#1248

Merged
synfinatic merged 1 commit intomainfrom
refactor-utils
Aug 5, 2025
Merged

refactor internal/utils into smaller packages#1248
synfinatic merged 1 commit intomainfrom
refactor-utils

Conversation

@synfinatic
Copy link
Owner

@synfinatic synfinatic commented Aug 5, 2025

No description provided.

@codecov
Copy link

codecov bot commented Aug 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 88.83249% with 22 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@b6bc45b). Learn more about missing BASE report.
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/fileutils/path.go 82.76% 3 Missing and 2 partials ⚠️
internal/sso/cache.go 58.34% 5 Missing ⚠️
internal/helper/helper.go 50.00% 1 Missing and 3 partials ⚠️
internal/sso/awssso.go 50.00% 3 Missing ⚠️
internal/sso/roles.go 62.50% 3 Missing ⚠️
internal/fileutils/fileedit.go 50.00% 1 Missing ⚠️
internal/sso/settings.go 66.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1248   +/-   ##
=======================================
  Coverage        ?   82.91%           
=======================================
  Files           ?       40           
  Lines           ?     3949           
  Branches        ?        0           
=======================================
  Hits            ?     3274           
  Misses          ?      579           
  Partials        ?       96
Flag Coverage Δ
unittests 82.91% <88.84%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/awsconfig/config.go 76.32% <100.00%> (ø)
internal/awsparse/awsparse.go 100.00% <100.00%> (ø)
internal/config/config.go 100.00% <100.00%> (ø)
internal/ecs/list_profiles_response.go 100.00% <100.00%> (ø)
internal/fileutils/logger.go 100.00% <100.00%> (ø)
internal/predictor/predictor.go 87.29% <100.00%> (ø)
internal/prompt/bellskipper.go 100.00% <ø> (ø)
internal/prompt/remote_host.go 100.00% <100.00%> (ø)
internal/sso/config.go 91.40% <100.00%> (ø)
internal/storage/json_store.go 94.45% <100.00%> (ø)
... and 11 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6bc45b...fdaf68a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@synfinatic synfinatic merged commit 183ed32 into main Aug 5, 2025
8 checks passed
@synfinatic synfinatic deleted the refactor-utils branch August 5, 2025 04:22
@BrewTestBot BrewTestBot mentioned this pull request Sep 3, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@synfinatic