Skip to content

Fix AuthUrlAction#1231

Merged
synfinatic merged 1 commit intomainfrom
fix-authurlaction
May 29, 2025
Merged

Fix AuthUrlAction#1231
synfinatic merged 1 commit intomainfrom
fix-authurlaction

Conversation

@synfinatic
Copy link
Owner

Fixes a regression in v2.0.2 where AuthUrlAction was no longer honored.

Fixes: #1230

@codecov
Copy link

codecov bot commented May 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.96%. Comparing base (190e9f8) to head (042de00).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1231      +/-   ##
==========================================
- Coverage   82.97%   82.96%   -0.01%     
==========================================
  Files          36       36              
  Lines        3957     3954       -3     
==========================================
- Hits         3283     3280       -3     
  Misses        578      578              
  Partials       96       96              
Flag Coverage Δ
unittests 82.96% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/sso/awssso_auth.go 89.69% <100.00%> (-0.13%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fdca4e...042de00. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Fixes a regression in v2.0.2 where `AuthUrlAction` was no longer
honored.

Fixes: #1230
@synfinatic synfinatic force-pushed the fix-authurlaction branch from 2aaf99c to 042de00 Compare May 29, 2025 14:54

[Unreleased]: https://github.com/synfinatic/aws-sso-cli/compare/v2.0.2...main
<!-- markdownlint-disable-next-line MD053 -->
[Unreleased]: https://github.com/synfinatic/aws-sso-cli/compare/v2.0.3...main

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [linkspector] reported by reviewdog 🐶
Cannot reach v2.0.3...main Status: 404

[Unreleased]: https://github.com/synfinatic/aws-sso-cli/compare/v2.0.2...main
<!-- markdownlint-disable-next-line MD053 -->
[Unreleased]: https://github.com/synfinatic/aws-sso-cli/compare/v2.0.3...main
[v2.0.3]: https://github.com/synfinatic/aws-sso-cli/releases/tag/v2.0.3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [linkspector] reported by reviewdog 🐶
Cannot reach https://github.com/synfinatic/aws-sso-cli/releases/tag/v2.0.3 Status: 404

@synfinatic synfinatic merged commit 5c1f920 into main May 29, 2025
7 of 8 checks passed
@synfinatic synfinatic deleted the fix-authurlaction branch May 29, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AuthUrlAction is no longer respected

1 participant