Skip to content

fix setup profiles forced re-auth#1215

Merged
synfinatic merged 1 commit intomainfrom
fix-setup-profiles
May 16, 2025
Merged

fix setup profiles forced re-auth#1215
synfinatic merged 1 commit intomainfrom
fix-setup-profiles

Conversation

@synfinatic
Copy link
Owner

@synfinatic synfinatic commented May 16, 2025 •
edited
Loading

  • setup profiles command now uses your cache and validates it has not expired.
  • if cache has expired, it will refresh without prompting you to login or fail if you have not logged in
  • fixes bug where non-default SSO instances were empty

Fixes: #1210

@codecov
Copy link

codecov bot commented May 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.23404% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.98%. Comparing base (f1c1720) to head (a8a855e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/sso/settings.go 77.78% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1215      +/-   ##
==========================================
+ Coverage   82.96%   82.98%   +0.03%     
==========================================
  Files          36       36              
  Lines        3918     3959      +41     
==========================================
+ Hits         3250     3285      +35     
- Misses        574      578       +4     
- Partials       94       96       +2
Flag Coverage Δ
unittests 82.98% <87.24%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/awsconfig/config.go 76.32% <100.00%> (ø)
internal/sso/cache.go 49.90% <100.00%> (+1.47%) ⬆️
internal/sso/settings.go 75.65% <77.78%> (+0.21%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1c1720...a8a855e. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@synfinatic synfinatic force-pushed the fix-setup-profiles branch from 63de92f to 3af32b3 Compare May 16, 2025 03:02
@synfinatic
fix setup profiles forced re-auth
a8a855e 
- setup profiles command now uses your cache and validates
    it has not expired.
- if cache has expired, it will refresh without prompting
    you to login or fail if you have not logged in
- fixes bug where non-default SSO instances were empty

Fixes: #1210
@synfinatic synfinatic force-pushed the fix-setup-profiles branch from 3af32b3 to a8a855e Compare May 16, 2025 03:20
@synfinatic synfinatic merged commit d51ccd6 into main May 16, 2025
7 checks passed
@synfinatic synfinatic deleted the fix-setup-profiles branch May 16, 2025 03:30
@BrewTestBot BrewTestBot mentioned this pull request May 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-sso setup profiles does not load the SSO Token from the cache

1 participant

@synfinatic