feat(gui): show restart message during auto-upgrade#10511
Closed
majiayu000 wants to merge 1 commit intosyncthing:mainfrom
Closed
feat(gui): show restart message during auto-upgrade#10511majiayu000 wants to merge 1 commit intosyncthing:mainfrom
majiayu000 wants to merge 1 commit intosyncthing:mainfrom
Conversation
…1248) Add a new UpgradeStarted event that is emitted when an automatic upgrade has been performed and Syncthing is about to restart. The GUI listens for this event and shows the "Syncthing is restarting" dialog instead of the misleading "Connection Error" message. This improves the user experience during automatic upgrades by providing a clear indication that the system is restarting as expected. Signed-off-by: majiayu000 <1835304752@qq.com>
Member
|
This will show a restarting dialog a full minute before the restart happens. |
Member
|
Please also note that any changes to the man pages are futile. They are generated from our separate documentation repository. You have to update the source there. |
Author
|
Closing this PR as I need more time to properly understand the upgrade timing and test the implementation in a real environment. Thank you for the feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #1248 by showing "Syncthing is restarting" instead of "Connection Error" when an automatic upgrade triggers a restart.
Changes
UpgradeStartedevent type inlib/events/events.goUpgradeStartedevent incmd/syncthing/main.gowhen auto-upgrade completes and restart is imminentgui/default/syncthing/core/eventService.jsto register the new eventgui/default/syncthing/core/syncthingController.jsto show the restarting dialog when the event is receivedman/syncthing-event-api.7Test plan
🤖 Generated with Claude Code