Skip to content

panics in failure reporting #7090

@imsodin

Description

@imsodin

https://sentry.syncthing.net/syncthing/syncthing/issues/4783

panic: interface conversion: interface {} is nil, not string

github.com/syncthing/syncthing/lib/ur/failurereporting.go in serve at line 97

    			}
    			url = opts.CRURL + "/failure"
    		case e := <-h.evChan:
    			descr := e.Data.(string)
    			if stat, ok := h.buf[descr]; ok {
    				stat.last = e.Time
    				stat.count++

github.com/syncthing/syncthing/lib/util/utils.go in Serve at line 300
github.com/thejerf/suture@v3.0.2+incompatible/supervisor.go in func1 at line 600

The channel is closed when unsubscribing, thus we receive from it. The channel was supposed to be set to nil on unsubscribe, but that doesn't happen.

Metadata

Metadata

Assignees

Labels

bugA problem with current functionality, as opposed to missing functionality (enhancement)frozen-due-to-ageIssues closed and untouched for a long time, together with being locked for discussion

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions