Skip to content

Folder defaults are not applied consistently on config migrations / new folders #6748

@calmh

Description

@calmh

We set some defaults in the FolderConfiguration struct definition. These are effectively only used for the initial "Sync" folder, because we only call SetDefaults in NewConfig and not when deserializing. The defaults for new folders are set in syncthingController.js. Defaults for new config options are never applied to existing folders.

Suggested cleanup:

  • Some hack to make sure we apply defaults on unmarshalling a config from XML/JSON.
  • A new REST API call .../folder-defaults that returns the default values to use to the GUI. Currently this can be just the compiled in defaults, but in the future one could imagine this being the result of compiled in defaults + user changeable ones...

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugA problem with current functionality, as opposed to missing functionality (enhancement)

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions