Skip to content

setLowPriority should not increase process priority when already lower (in Windows) #6597

@tomasz1986

Description

@tomasz1986

Syncthing, with setLowPriority set to true, always sets its child process priority to Below normal, even if the parent priority is already lower than that.

To reproduce in Windows command line:

start /low syncthing.exe

Even though the parent process priority is Idle, the child process priority gets changed to Below normal.

image

On the other hand, with setLowPriority set to false, the child process priority remains Idle, following its parent priority.

image

I would argue that setLowPriority should not make Syncthing change its priority to a higher value than the one already defined on runtime.

Version Information

Syncthing Version: v1.4.2
OS Version: Windows 10 Enterprise 1607 LTSB

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugA problem with current functionality, as opposed to missing functionality (enhancement)frozen-due-to-ageIssues closed and untouched for a long time, together with being locked for discussion

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions