Adding linting for the new add-lines configurator#14
Merged
fabpot merged 1 commit intosymfony-tools:mainfrom May 26, 2023
Merged
Adding linting for the new add-lines configurator#14fabpot merged 1 commit intosymfony-tools:mainfrom
fabpot merged 1 commit intosymfony-tools:mainfrom
Conversation
stof
requested changes
May 24, 2023
Contributor
Author
|
Good suggestions - I implemented both and tested it locally. |
stof
reviewed
May 24, 2023
| } | ||
|
|
||
| if (!is_string($addLine[$key])) { | ||
| $output->writeln(sprintf('::error file=%s::"add-lines" has a "%s" key but it must be a string value', $manifest, $key)); |
Member
There was a problem hiding this comment.
Maybe those error messages should indicate for which item of $data they are, given that we are not able to associate the error with a precise line in the file.
Contributor
Author
There was a problem hiding this comment.
Good idea. It's a bit tricky to know WHAT to show - so I included the index integer of where this is inside of add-lines.
stof
approved these changes
May 25, 2023
Contributor
|
Thank you @weaverryan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports symfony/flex#975