test(deps): replace Zombie by Puppeteer#1331
Merged
Kocal merged 1 commit intosymfony:mainfrom Sep 6, 2024
Merged
Conversation
24fc72b to
24757cf
Compare
stof
reviewed
Sep 5, 2024
732d61a to
7eb7fe1
Compare
stof
approved these changes
Sep 6, 2024
Member
stof
left a comment
There was a problem hiding this comment.
You need to rebase to fix conflict on the yarn.lock file, but otherwise, things look fine.
7eb7fe1 to
39807a7
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/assaf/zombie is archived since december 2023, and its last release is from 4 years ago.
I've replaced it by https://github.com/puppeteer/puppeteer, a modern and maintained API to run and test code in a real browser (zombie used
jsdom). I had to adaptrequestTestPageto pass the browser as first argument, because I want to launch the browser only a single time (inbefore()).