Conversation
|
Can you also run |
|
I've update the package.json and yarn.lock |
|
Tests still failing - I think we actually need to go into the 3 |
|
@abozhinov Do y ou need any help? |
|
I run yarn install on each yarn-pnp-* directory but didn't help. |
|
I don't know why the yarn.lock files was changed... I've recreate it with the newest packages ... |
|
@abozhinov this is because of last weeks yarn 4.1 release. I'll make separate PR to update the test_app setups. Meanwhile, I updated the lockfiles and I've made PR into your fork. It will pass all the tests abozhinov#1 |
|
@stof @weaverryan can you please have another look on this? |
|
@stof @weaverryan is there anything that needs correcting before this PR can be merged in? |
|
.bump. |
|
Works for me |
|
What about eslint? See #1267 |
|
Oopsy daisy |
|
Hi everyone, and sorry for the big delay! Just to let you know, very soon a new version will be tagged with a lot of dependencies updates (see https://github.com/symfony/webpack-encore/milestone/3) |
Hello,
I have dependency errors because using newest postcss, less, stylus loaders and for that we need to allow them in the package.json file. This PR will not break anything and it's pretty safe to merge it.