Skip to content

Allow fork-ts-checker-webpack-plugin ^8.0 and ^9.0#1224

Merged
weaverryan merged 1 commit intosymfony:mainfrom
buffcode:feat/fork-ts-checker-webpack-plugin
Oct 20, 2023
Merged

Allow fork-ts-checker-webpack-plugin ^8.0 and ^9.0#1224
weaverryan merged 1 commit intosymfony:mainfrom
buffcode:feat/fork-ts-checker-webpack-plugin

Conversation

@buffcode
Copy link
Contributor

@buffcode buffcode commented Oct 19, 2023

Widen allowed scope of fork-ts-checker-webpack-plugin to v8 and v9.

@buffcode
Copy link
Contributor Author

buffcode commented Oct 19, 2023

Failing test seems to be unrelated to this MR:

  1) The config-generator function
       enableEslintPlugin() adds the eslint-webpack-plugin
         enableEslintPlugin():
     Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (D:\a\webpack-encore\webpack-encore\test\config-generator.js)
      at processImmediate (node:internal/timers:466:21)

@weaverryan
Copy link
Contributor

weaverryan commented Oct 20, 2023

Thanks @buffcode!

@weaverryan weaverryan merged commit f6ae192 into symfony:main Oct 20, 2023
@buffcode buffcode deleted the feat/fork-ts-checker-webpack-plugin branch October 20, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@buffcode @weaverryan