Phase 8: Migrate vendor overrides to Tailwind#146
Merged
Conversation
Move the last vendor SCSS overrides into Tailwind CSS, dropping the matching `@import`s from app.scss. - 8.1 vendor/_highlight.scss -> vendor/_highlight.css (@layer components, pure custom syntax colors, no Bootstrap dependency) - 8.2 vendor/_tom-select.scss -> vendor/_tom-select.css (@layer components, --bs-* vars replaced by --color-* tokens). The bootstrap5 base theme is loaded unlayered, so the overrides need !important to win the cascade (unlayered declarations beat layered ones). - 8.5 Remove dead _images.scss (component-img/live-component-img/ img-dark-negative classes are no longer referenced anywhere) 8.3 (_bootstrap.scss) stays until Phase 9: btn-copy, btn-outline-primary and btn-sm are still used in templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the last vendor SCSS overrides into Tailwind CSS, dropping the
matching
@imports from app.scss.pure custom syntax colors, no Bootstrap dependency)
--bs-* vars replaced by --color-* tokens). The bootstrap5 base theme is
loaded unlayered, so the overrides need !important to win the cascade
(unlayered declarations beat layered ones).
img-dark-negative classes are no longer referenced anywhere)
8.3 (_bootstrap.scss) stays until Phase 9: btn-copy, btn-outline-primary
and btn-sm are still used in templates.