Phase 7: Migrate sections#145
Merged
Merged
Conversation
eb62a61 to
80a50b0
Compare
Phase 7 of the Bootstrap -> Tailwind migration (symfony#34). Header / nav are now fully utility-first, with no dedicated stylesheet: - Express the whole header in Tailwind utilities in _header.html.twig, including the blurred ::before overlay (before:* utilities), the open transition (@starting-style via the starting: variant + transition-discrete), the mobile slide-in menu and social reveal (nav:/max-nav:, group-[.open]:), and the light/white theming through conditional classes (text-white / dark:invert / before:bg-*) instead of CSS custom properties. - Extract the repeated markup into Twig components to avoid duplicating long class lists: AppNav:Item (nav link, optional badge + responsive hide), AppNav:Badge, AppNav:IconLink (social icon). - Scroll-lock now toggles the Tailwind overflow-y-hidden class on body from the ux-header controller (was a custom .locked rule). - The ThemeSwitcher icon inherits the header color (text-current) so it stays white on the white package header. Hero: - Convert .hero/.hero-background/.hero-sub-text to utilities across the ~14 templates that used them (pt-20/pt-16, w-1/2 + responsive widths, text-balance). Drop the unused .hero-terminal rule. Cleanup: - Remove the three section imports from app.scss and delete _header.scss, _nav.scss, _hero.scss. No section stylesheet remains. - Update IconsTest to look for the Icons link in the header element (the .AppNav_menu class no longer exists). Verified light/dark on desktop, white package header, and mobile (slide-in menu, blur overlay with starting-style fade, social reveal, body scroll lock).
80a50b0 to
4da5dea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Damn, Claude Opus 4.8 was insanely useful here, computed for ~25min