[Toolkit] Allow declaring kit-global dependencies in kit manifest#3671
Merged
Conversation
The `JsImportChecker` only matched JS imports against per-recipe npm/importmap dependencies, so kit-global libraries (e.g. flowbite, installed once via the kit's ` INSTALL.md) were reported as `js.import.undeclared` on every recipe. Add a `dependencies` object (composer/npm/importmap) to the kit manifest and have JsImportChecker treat kit-level npm/importmap packages as available for all recipes. Extract the shared parsing into DependencyParser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
JsImportCheckeronly matched JS imports against per-recipe npm/importmapdependencies, so kit-global libraries (e.g. flowbite, installed once via the
kit's
INSTALL.md) were reported asjs.import.undeclared` on every recipe.Add a
dependenciesobject (composer/npm/importmap) to the kit manifest andhave JsImportChecker treat kit-level npm/importmap packages as available for
all recipes. Extract the shared parsing into DependencyParser.