Skip to content

Adding phpunit directly to the pack#10

Merged
nicolas-grekas merged 1 commit intosymfony:mainfrom
weaverryan:adding-phpunit
May 31, 2021
Merged

Adding phpunit directly to the pack#10
nicolas-grekas merged 1 commit intosymfony:mainfrom
weaverryan:adding-phpunit

Conversation

@weaverryan
Copy link
Copy Markdown
Contributor

@weaverryan weaverryan commented Feb 27, 2021 •
edited
Loading

@weaverryan weaverryan mentioned this pull request Feb 27, 2021
Merged
@weaverryan weaverryan changed the title [WIP] Adding phpunit directly to the pack Adding phpunit directly to the pack Mar 23, 2021
@weaverryan weaverryan changed the title Adding phpunit directly to the pack [WIP] Adding phpunit directly to the pack Mar 23, 2021
@nicolas-grekas
Copy link
Copy Markdown
Member

nicolas-grekas commented Mar 23, 2021

Same comment in https://github.com/symfony/recipes/pull/906/files#issuecomment-805326748

👍 from purely technical pov.

nicolas-grekas
nicolas-grekas reviewed Mar 23, 2021
View reviewed changes
Comment thread composer.json Outdated
"symfony/css-selector": "*",
"symfony/phpunit-bridge": "*"
"symfony/phpunit-bridge": "*",
"phpunit/phpunit": "*"
Copy link
Copy Markdown
Member

@nicolas-grekas nicolas-grekas Mar 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alpha ordering rulez?

Copy link
Copy Markdown
Member

@nicolas-grekas nicolas-grekas Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or not, because the order drives the order of recipes, right?

Copy link
Copy Markdown
Contributor Author

@weaverryan weaverryan Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it. I think it won't matter, but after we merge, I'll double-check that. phpunit/phpunit and phpunit-bridge both share a few files (like tests/bootstrap.php) but ordering doesn't cause a problem there. And, thanks to the now-merged recipe PR, phpunit/phpunit no longer has a post-install text, so no problem there either.

@nicolas-grekas
Copy link
Copy Markdown
Member

nicolas-grekas commented Mar 24, 2021

Can't we merge now, but tag only when 5.3 comes out?

@weaverryan
Copy link
Copy Markdown
Contributor Author

weaverryan commented Mar 24, 2021

Can't we merge now, but tag only when 5.3 comes out?

That's a good idea. I'll add a reminder for myself near the end of May to ping for a tag.

@weaverryan weaverryan changed the title [WIP] Adding phpunit directly to the pack Adding phpunit directly to the pack Mar 24, 2021
@nicolas-grekas nicolas-grekas merged commit d6da992 into symfony:main May 31, 2021
@weaverryan weaverryan deleted the adding-phpunit branch May 31, 2021 15:35
@VincentLanglet VincentLanglet mentioned this pull request Jun 6, 2021
Closed
@VincentLanglet VincentLanglet mentioned this pull request Oct 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

+3 more reviewers

@stof stof stof approved these changes

@wouterj wouterj wouterj approved these changes

@Nyholm Nyholm Nyholm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@weaverryan @nicolas-grekas @stof @wouterj @Nyholm