Closed
Conversation
Member
dunglas
commented
Dec 16, 2015
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes symfony/symfony#15613 |
| Applies to | 2.8, 3.0 |
| Fixed tickets | n/a |
Contributor
|
👍 |
Member
There was a problem hiding this comment.
seems like "and" should be removed here.
Member
Author
|
@theofidry and @wouterj changes merged. |
Contributor
|
we don't have the doc preview anymore? |
Member
|
@theofidry Thanks for noticing. I opened an issue (see #6074). |
Member
There was a problem hiding this comment.
I think we should change this title. People who know nothing about "autowiring" will never look for that in Google. Maybe we could change it for "Defining Services Dependencies Automatically" or something similar that explains what does "autowiring" solve.
Member
|
I left some comments, but overall the article looks really nice! @dunglas thanks for contributing both the feature and the docs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.