Conversation
weaverryan
commented
Nov 27, 2015
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | 2.8+ |
| Fixed tickets | #5728 |
|
Here's the code behind this post: https://github.com/weaverryan/docs-voters/tree/finished |
25f6776 to
5d0e6b2
Compare
|
👍 |
There was a problem hiding this comment.
Why changing the namespace to use AppBundle\Security instead of AppBundle\Security\Authorization\Voter ?
If the application grows, it could have many things in the Security namespace. I think the cookbooks are good indications for a new developper to know where to place common things and promote some standard directory structures.
There was a problem hiding this comment.
I agree partially with @ogizanagi. Why not using AppBundle\Security\Voter as the namespace?
There was a problem hiding this comment.
AppBundle\Security\Voter is fine to me too. 👍
I only have for habit to replicate the subnamespace of the component used for such things.
There was a problem hiding this comment.
As the best practice is to not clutter the AppBundle\Form with different sub-namespaces I'd say let's be consistent with that decision and do not introduce sub-namespaces here.
There was a problem hiding this comment.
I agree with @xabbuh. There is no perfect answer, but I do hate telling people to create one directory, then another directory inside that directory before doing something.
cookbook/security/voters.rst
Outdated
There was a problem hiding this comment.
we should avoid using "we" here
|
Thanks for the awesome review guys! |