Added chapter about the locale based on the user entity#4875
Added chapter about the locale based on the user entity#4875weaverryan merged 4 commits intosymfony:2.3from peterrehm:locale-user-dependend
Conversation
peterrehm
commented
Jan 17, 2015
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | 2.3 |
| Fixed tickets | #4862 |
There was a problem hiding this comment.
Original:
You might want to improve even further and want to define the locale based on
the user entity of the logged in user.
Proposed rewording:
You might want to improve this technique even further and define the locale based on
the user entity of the logged in user.
|
@peterrehm thanks for adding this nice addition to the cookbook. I've made lots of comments, but they are minor things about the syntax. Your contents are right and that's the important thing. Thanks! |
There was a problem hiding this comment.
"Setting the Locale based on the User Entity"
|
Thank you for the feedback on the chapter, I have made the adjustments based on our discussion. Let's see when @xabbuh wakes up I expect the next e-mail flood :) |
|
Thanks for this great work @peterrehm! I left you a few comments. :) However, I have one thought I would like to discuss with you: I am not convinced that we should actually talk about entities at all. In fact, it doesn't really matter if the user is stored in a relation database or if you load them from a custom file format or anything else. So I'd suggest to talk about "Choosing the Locale Based on the User's Preferences" or something like that. What do you think? |
|
Thank you for your feedback, I was awaiting that :) I changed it in the title to preferences, but we mainly talk about entities. I think it makes it more clear that you also have to watch out for changes to the entity as in the end in the caution block. |
|
I think this one is finished now? |