Completely re-reading the controller chapter#4433
Conversation
book/controller.rst
Outdated
There was a problem hiding this comment.
You have to remove the underscore after the doc role.
+1, I was about doing the same in my PR :) |
book/controller.rst
Outdated
There was a problem hiding this comment.
This sentence doesn't sound complete.
|
let's postpone this to post-2.6 :) |
|
@wouterj while not strictly related to 2.6, I'd like to have things like this done as close to 2.6 launch as possible. There is a good amount of work, but I don't want to postpone and drag it on. Now, that would require me finding time of course. So, I'm not saying you're wrong, I'm more saying that I want to do this kind of stuff before 2.6 ;). Thanks! |
|
@weaverryan I predict that I'm not able to review this PR before 2.6, given the amount of work that has more priority (best practices update, missing 2.6 features, sf installer, etc.) That was my reason to say I would like to postpone this :) |
I could find very little real use-cases for this.
Hi guys!
This follows #4427, but only for the controller chapter (I will open separate PR's for
from_flat_php_to_symfony2,routing, andtemplating).This is more than just updating for the best practices. This is about face-lifting these important chapters after several years of us as a community realizing what's more important and what's less important. More notes:
defaultsto pass additional information to your controller from this chapter. This is too early and we have this now: http://symfony.com/doc/current/cookbook/routing/extra_information.htmlContainerAwareinformation. This is not the right spot... and maybe nothing is. I don't see much use-case for this - it seems like you'd either extend the base Controller or register your controller as a service.Thanks!