New Feature: Change the Default Command in the Console component#3426
New Feature: Change the Default Command in the Console component#3426weaverryan merged 9 commits intosymfony:masterfrom
Conversation
There was a problem hiding this comment.
you should remove this file comment, it's symfony specific and that's not something we do in the component docs.
|
You should also keep the previous file and say "This article is moved to ...", otherwise we get lots of broken links. |
|
@wouterj thanks for your review! |
the document was moved to another location
the standalone component
There was a problem hiding this comment.
This does aply to the section started on line 16, not to the hole article, does it?
There was a problem hiding this comment.
yes true! will move it to the right section
There was a problem hiding this comment.
missing comma after Fortunately I think
There was a problem hiding this comment.
I think this should stay in a separate page, as it is a totally separate feature than changing the default command
There was a problem hiding this comment.
Actually, I think the best solution is to keep it in its original location. It may be referenced from the page about changing the default command, to wanT than changing the default is not the best way if you only want 1 command, but it should not be in the same page IMO. It makes it harder to find the feature
There was a problem hiding this comment.
+1, and it would also solve the redirect_map problem I think :)
I followed the suggestion from @wouterj in IRC on changing the
single_command_tooland added the documentation for the new feature there.