[BrowserKit] Allow Cookie expiration to be an int#62758
Merged
nicolas-grekas merged 1 commit intosymfony:6.4from Dec 13, 2025
Merged
[BrowserKit] Allow Cookie expiration to be an int#62758nicolas-grekas merged 1 commit intosymfony:6.4from
nicolas-grekas merged 1 commit intosymfony:6.4from
Conversation
Member
|
Thank you @derrabus. |
This was referenced Dec 31, 2025
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constructor parameter
$expiresof theCookieclass is typed asstring|null. That is surprising because that parameter is expected to be provided as a Unix timestamp which is usually an integer. Also, looking at the tests and the documentation, we commonly call that constructor with an integer ourselves, usually with a value returned bystrtotime().symfony/src/Symfony/Component/BrowserKit/Tests/CookieTest.php
Line 23 in b96b6bb
Creating a
Cookieobject as documented in a codebase that uses strict types will cause aTypeError.In this PR, I'm widening the parameter type to
string|int|null. This should not be a problem because while validating the value, we convert it back to a string anyway.symfony/src/Symfony/Component/BrowserKit/Cookie.php
Lines 77 to 84 in b96b6bb