Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
the link in the issue description is a 404. Is this a link pointing to a private repository ? |
Sorry, I fixed the link. |
|
this should be done in an older branch than 8.1 IMO. |
|
Thank you @tillkruss. |
This test was disabled and should not longer segfault.