Skip to content

[ObjectMapper] read source metadata before transform#61310

Merged
nicolas-grekas merged 2 commits intosymfony:7.3from
soyuka:fix-61027
Aug 12, 2025
Merged

[ObjectMapper] read source metadata before transform#61310
nicolas-grekas merged 2 commits intosymfony:7.3from
soyuka:fix-61027

Conversation

@soyuka
Copy link
Copy Markdown
Contributor

@soyuka soyuka commented Aug 3, 2025

Q A
Branch? 7.3
Bug fix? yes
New feature? no
Deprecations? no
Issues fixes #61027
License MIT

@nicolas-grekas
Copy link
Copy Markdown
Member

Needs to account for #61027 (comment)? /cc @rvanlaak

@rvanlaak
Copy link
Copy Markdown
Contributor

rvanlaak commented Aug 5, 2025

Needs to account for #61027 (comment)? /cc @rvanlaak

Will verify this within the hour, and potentially provide a commit with a test case to cherry-pick.

@rvanlaak
Copy link
Copy Markdown
Contributor

rvanlaak commented Aug 5, 2025

@soyuka @nicolas-grekas added PR soyuka#2 with a test case and fix for #61027 (comment)

@nicolas-grekas
Copy link
Copy Markdown
Member

Thank you @soyuka.

@nicolas-grekas nicolas-grekas merged commit 50cd48c into symfony:7.3 Aug 12, 2025
11 checks passed
@nicolas-grekas
Copy link
Copy Markdown
Member

And thank you @rvanlaak

@rvanlaak
Copy link
Copy Markdown
Contributor

As can be read on soyuka#2 the 7.3.2 release actually introduced a regression for ObjectMapper, as our CI pipeline was failing on the Renovatebot update PR to that release. As patch releases usually appear once per month, could this edge case regression on the experimental component be considered to be severe enough for an extra patch release in the upcoming days? 🙌

@xabbuh
Copy link
Copy Markdown
Member

xabbuh commented Aug 12, 2025

Are there any other changes in 7.3.2 that make it impossible to downgrade to 7.3.1/7.3.0 for the time until 7.3.3 is fixed at the regular schedule?

@rvanlaak
Copy link
Copy Markdown
Contributor

No. And the BC itself is on an edge case, so scope of the impact is limited.

We solely can not update to 7.3.2 and will stay on 7.3.1 until this PR gets released and our CI will turn green. It's mostly my over-eagerness that's asking that wants to start dropping all the boilerplate code for ObjectMapper implementations.

@xabbuh
Copy link
Copy Markdown
Member

xabbuh commented Aug 12, 2025

I guess that's not an important enough reason for an extra release. 😉

@fabpot fabpot mentioned this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants