[TypeInfo] Fix handling `ConstFetchNode` by norkunas · Pull Request #60820 · symfony/symfony

norkunas · 2025-06-18T11:21:49Z

Q	A
Branch?	7.2
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues	Fix #...
License	MIT

I cannot upgrade to 7.3 because I get:

  In StringTypeResolver.php line 88:
!!                                                                                 
!!    Cannot resolve "array{requirement: ProductLicense::SYSTEM_REQUIREMENT_*, va  
!!    lue: non-empty-string}".                                                     
!!                                                                                 
!!  
!!  In StringTypeResolver.php line 142:
!!                                                                                 
!!    Unhandled "PHPStan\PhpDocParser\Ast\ConstExpr\ConstFetchNode" constant expr  
!!    ession.                                                                      
!!

norkunas · 2025-06-18T11:26:27Z

Hmm, this is not the right fix :(

norkunas · 2025-06-18T11:43:09Z

Changed implementation from returning Type::string() to any union-scalar

stof · 2025-06-18T11:46:21Z

Constants are not even restricted to scalars in recent PHP versions.

The right fix would involve looking at the fetched constants.

norkunas · 2025-06-19T09:55:17Z

I've updated implementation

src/Symfony/Component/TypeInfo/TypeResolver/StringTypeResolver.php

norkunas · 2025-06-20T10:17:10Z

I'm not sure how to fix the failing serializer test. For me it looks like that it's an invalid test, because it defines self::* on an anonymous class but does not define any constant. Then later of course it fails because it's an union type, but for now when no matched constants were found it returns Type::null and as property defines also null, it tries to pass Type::null to Type::union twice.

norkunas · 2025-06-26T04:32:16Z

@stof @mtarld so I just fixed the wrong test from Serializer, please review when you can :)

norkunas · 2025-06-26T04:37:47Z

I'm not sure how to fix property info though, as test passes for me locally

norkunas · 2025-06-27T11:10:37Z

Thanks, updated

src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php

stof · 2025-06-27T12:02:47Z

For the lowest-deps job, I suggest instead bumping the min version of type-info in property-info to use ^7.2.8 (i.e. the next 7.2 release that will contain the fix). It makes maintenance easier than having conditional test assertions depending on the version, while type-into 7.1 is EOL anyway.

mtarld · 2025-06-27T12:04:39Z

Agreed, this will make things much more easier.

norkunas · 2025-06-27T12:10:06Z

Thank you, both

src/Symfony/Component/PropertyInfo/composer.json

src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php

nicolas-grekas · 2025-06-27T15:23:23Z

Thank you @norkunas.

…t type instead of enum (norkunas) This PR was squashed before being merged into the 7.3 branch. Discussion ---------- [TypeInfo] Fix `Type::fromValue` incorrectly setting object type instead of enum | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #... | License | MIT Tried to apply #60820 (comment) comment, but found some failing cases Commits ------- a0cdd3f [TypeInfo] Fix `Type::fromValue` incorrectly setting object type instead of enum

…s` for `ConstFetchNode` (norkunas) This PR was merged into the 7.3 branch. Discussion ---------- [TypeInfo] Reuse `CollectionType::mergeCollectionValueTypes` for `ConstFetchNode` | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | #60820 (comment) | License | MIT Commits ------- 4187201 [TypeInfo] Reuse `CollectionType::mergeCollectionValueTypes` for `ConstFetchNode`

…s` for `ConstFetchNode` (norkunas) This PR was merged into the 7.3 branch. Discussion ---------- [TypeInfo] Reuse `CollectionType::mergeCollectionValueTypes` for `ConstFetchNode` | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | symfony/symfony#60820 (comment) | License | MIT Commits ------- 41872011b1b [TypeInfo] Reuse `CollectionType::mergeCollectionValueTypes` for `ConstFetchNode`

carsonbot added Status: Needs Review Bug TypeInfo labels Jun 18, 2025

This comment was marked as outdated.

Sign in to view

carsonbot added this to the 7.4 milestone Jun 18, 2025

norkunas changed the base branch from 7.4 to 7.2 June 18, 2025 11:22

norkunas force-pushed the typeinfo-const-fetch-node branch from 38d6ac6 to 526b002 Compare June 18, 2025 11:26

norkunas requested a review from dunglas as a code owner June 18, 2025 11:26

norkunas force-pushed the typeinfo-const-fetch-node branch from 526b002 to 6e237a9 Compare June 18, 2025 11:42

OskarStark changed the title ~~[TypeInfo] Fix handling ConstFetchNode~~ [TypeInfo] Fix handling ConstFetchNode Jun 18, 2025

OskarStark modified the milestones: 7.4, 7.2 Jun 18, 2025

norkunas force-pushed the typeinfo-const-fetch-node branch from 6e237a9 to 48f648b Compare June 19, 2025 09:55

norkunas force-pushed the typeinfo-const-fetch-node branch 3 times, most recently from 4173b66 to 606a4ab Compare June 19, 2025 10:23

stof requested changes Jun 19, 2025

View reviewed changes

src/Symfony/Component/TypeInfo/TypeResolver/StringTypeResolver.php Show resolved Hide resolved

src/Symfony/Component/TypeInfo/TypeResolver/StringTypeResolver.php Show resolved Hide resolved

src/Symfony/Component/TypeInfo/TypeResolver/StringTypeResolver.php Show resolved Hide resolved

carsonbot added Status: Needs Work and removed Status: Needs Review labels Jun 19, 2025

norkunas force-pushed the typeinfo-const-fetch-node branch from 606a4ab to 3d5c90d Compare June 19, 2025 10:48

mtarld reviewed Jun 19, 2025

View reviewed changes

src/Symfony/Component/TypeInfo/TypeResolver/StringTypeResolver.php Show resolved Hide resolved

stof mentioned this pull request Jun 24, 2025

PropertyInfo - PhpStanExtractor - File validator constraint: Cannot resolve "(self::FILENAME_COUNT_* | null) #60889

Closed

norkunas force-pushed the typeinfo-const-fetch-node branch from 3d5c90d to 2ac811b Compare June 26, 2025 04:31

norkunas force-pushed the typeinfo-const-fetch-node branch from d520350 to ec86f71 Compare June 27, 2025 11:05

mtarld reviewed Jun 27, 2025

View reviewed changes

src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php Outdated Show resolved Hide resolved

norkunas force-pushed the typeinfo-const-fetch-node branch from ec86f71 to 6f49fc6 Compare June 27, 2025 11:24

norkunas force-pushed the typeinfo-const-fetch-node branch from 6f49fc6 to 78c60fe Compare June 27, 2025 12:07

stof approved these changes Jun 27, 2025

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels Jun 27, 2025

stof reviewed Jun 27, 2025

View reviewed changes

src/Symfony/Component/PropertyInfo/composer.json Outdated Show resolved Hide resolved

norkunas force-pushed the typeinfo-const-fetch-node branch 2 times, most recently from 7729498 to 6440799 Compare June 27, 2025 12:28

stof approved these changes Jun 27, 2025

View reviewed changes

mtarld approved these changes Jun 27, 2025

View reviewed changes

src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php Outdated Show resolved Hide resolved

norkunas commented Jun 27, 2025

View reviewed changes

src/Symfony/Component/PropertyInfo/Tests/Extractor/PhpStanExtractorTest.php Outdated Show resolved Hide resolved

[TypeInfo] Fix handling ConstFetchNode

03cc607

nicolas-grekas force-pushed the typeinfo-const-fetch-node branch from d0fdf06 to 03cc607 Compare June 27, 2025 15:23

nicolas-grekas merged commit 4e3a96f into symfony:7.2 Jun 27, 2025
7 of 11 checks passed

norkunas deleted the typeinfo-const-fetch-node branch June 27, 2025 15:24

This was referenced Jun 28, 2025

Release v7.2.8 #60937

Merged

Release v7.3.1 #60938

Merged

norkunas mentioned this pull request Jun 30, 2025

[TypeInfo] Fix Type::fromValue incorrectly setting object type instead of enum #60956

Merged

norkunas mentioned this pull request Jul 1, 2025

[TypeInfo] Reuse CollectionType::mergeCollectionValueTypes for ConstFetchNode #61014

Merged

renovate bot mentioned this pull request Jul 14, 2025

fix(deps): update app_platform - autoclosed jeboehm/mailserver-admin#191

Closed

Uh oh!

Conversation

norkunas commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

norkunas commented Jun 18, 2025

Uh oh!

norkunas commented Jun 18, 2025

Uh oh!

stof commented Jun 18, 2025

Uh oh!

norkunas commented Jun 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

norkunas commented Jun 20, 2025

Uh oh!

norkunas commented Jun 26, 2025

Uh oh!

norkunas commented Jun 26, 2025

Uh oh!

norkunas commented Jun 27, 2025

Uh oh!

Uh oh!

stof commented Jun 27, 2025

Uh oh!

mtarld commented Jun 27, 2025

Uh oh!

norkunas commented Jun 27, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicolas-grekas commented Jun 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

norkunas commented Jun 18, 2025 •

edited

Loading