[FrameworkBundle] Deprecate loose as an email validation mode#60706
Closed
rhel-eo wants to merge 1 commit intosymfony:7.4from
rhel-eo:deprecate-email-validation-loose
Closed
[FrameworkBundle] Deprecate loose as an email validation mode#60706rhel-eo wants to merge 1 commit intosymfony:7.4from rhel-eo:deprecate-email-validation-loose
loose as an email validation mode#60706rhel-eo wants to merge 1 commit intosymfony:7.4from
rhel-eo:deprecate-email-validation-loose
Conversation
Member
|
I just created UPGRADE-7.4.md, please rebase and then you'll be able to amend it. |
Member
There was a problem hiding this comment.
I merged your other PR up to 8.0. Rebase needed. But then, you'll notice that nothing will remain of this PR.
The reason is that the current patch doesn't deprecate anything. It drops the loose mode.
Deprecating would mean triggering a deprecation when this mode is configured (which means the value should still be accepted also)
This will need a line in the changelog file of the bundle.
and the test case using "loose" should be either removed or insulated in a dedicated test with the @group legacy annotation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #60705 to deprecate the
looseemail validation config, which is not supported. It is only allowed in 7.0 -> 7.3 for backwards compatibility with existing configs. This will need to be rebased after that PR is merged, which will also involve removing a test that will now fail.I could not find a
UPGRADE-7.4.mdor a7.4section inFrameworkBundle/CHANGELOG.md. Should I add one?