Skip to content

[TypeInfo] Fix type alias resolving#60641

Merged
nicolas-grekas merged 1 commit intosymfony:7.3from
mtarld:fix/type-alias-resolving
Jun 4, 2025
Merged

[TypeInfo] Fix type alias resolving#60641
nicolas-grekas merged 1 commit intosymfony:7.3from
mtarld:fix/type-alias-resolving

Conversation

@mtarld
Copy link
Copy Markdown
Contributor

@mtarld mtarld commented Jun 2, 2025 •
edited by stof
Loading

Q A
Branch? 7.3
Bug fix? yes
New feature? no
Deprecations? no
Issues Fixes #60598, fixes #60657
License MIT

Take other type aliases into account when resolving type aliases, no matter the order they're defined.

@carsonbot carsonbot added this to the 7.3 milestone Jun 2, 2025
OskarStark
OskarStark reviewed Jun 3, 2025
View reviewed changes
@mtarld mtarld force-pushed the fix/type-alias-resolving branch from bd75b30 to 1bcb588 Compare June 3, 2025 07:09
stof
stof reviewed Jun 3, 2025
View reviewed changes
@mtarld mtarld force-pushed the fix/type-alias-resolving branch 2 times, most recently from cde4768 to b9335c0 Compare June 3, 2025 10:40
@mtarld mtarld requested a review from stof June 3, 2025 10:40
@mtarld mtarld mentioned this pull request Jun 3, 2025
Closed
nicolas-grekas
nicolas-grekas approved these changes Jun 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty value comparisons... 🔫

@mtarld mtarld force-pushed the fix/type-alias-resolving branch from b9335c0 to b778a80 Compare June 4, 2025 09:26
@nicolas-grekas
Copy link
Copy Markdown
Member

nicolas-grekas commented Jun 4, 2025

Thank you @mtarld.

@nicolas-grekas nicolas-grekas merged commit 70ccb7e into symfony:7.3 Jun 4, 2025
9 of 11 checks passed
@mtarld mtarld deleted the fix/type-alias-resolving branch June 4, 2025 09:57
@fabpot fabpot mentioned this pull request Jun 28, 2025
Merged
@Seldaek
Copy link
Copy Markdown
Member

Seldaek commented Jul 29, 2025 •
edited
Loading

This looks nice but any chance of loading type aliases defined in the phpstan.neon file? :s I get a crash in cache warmup on 7.3.1 because it doesn't know some type that is defined in there like:

parameters:
    typeAliases:
        \Type\Language: 'value-of<\App\Locale\Languages::LOCALES>'

Then on user class we have:

/**
 * @phpstan-type UserAttributes array{
 *     language?: \Type\Language
 * }
 */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OskarStark OskarStark OskarStark left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

Assignees

No one assigned

Labels

Bug Status: Reviewed TypeInfo

Projects

None yet

Milestone

7.3

Development

Successfully merging this pull request may close these issues.

6 participants

@mtarld @nicolas-grekas @Seldaek @stof @OskarStark @carsonbot